Fix tests when not building the Python package + other minor fixes #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows these tests to work even when the Python package is not present.
Converting between different mechanism formats require at least the "minimal" Python package to be built.
This was generating warnings from Clang.
In the default case where the 'python_prefix' variable is '$prefix', the Python module would get installed to the literal '$prefix' subdirectory of the staging directory, instead of actually expanding the '$prefix' variable. Fixes a regression introduced in c7a5d18.
Codecov Report
@@ Coverage Diff @@
## main #1100 +/- ##
==========================================
- Coverage 73.49% 73.49% -0.01%
==========================================
Files 364 364
Lines 47750 47749 -1
==========================================
- Hits 35096 35095 -1
Misses 12654 12654
Continue to review full report at Codecov.
|
bryanwweber
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
stage_dirlocation (fixes regression from c7a5d18)UnknownThermoPhaseModelandUnknownKineticsModelexception classesIf applicable, fill in the issue number this pull request is fixing
Closes #1095
Checklist
scons build&scons test) and unit tests address code coverage